docs(vector): document oversize dead-letter reason and failure-mode comments

Round-4 review nits on PR #920 (none blocking):
- record_document_dead_lettered: enumerate the oversize reason (added this PR)
  alongside timeout/oom/error in the docstring + counter comment.
- Note the clear-dead-letter-before-upsert ordering implication (a transient
  upsert failure re-parses once, never a silent drop).
- Clarify the orphan sweep's kept counter for tenant-wide dead-letter markers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-17 19:38:12 +02:00
co-authored by Claude Opus 4.8
parent a7f7461716
commit 114af7bf12
3 changed files with 8 additions and 2 deletions
@@ -316,7 +316,7 @@ document_parse_failed_total = Counter(
document_dead_lettered_total = Counter(
"astrolabe_document_dead_lettered_total",
"Documents dead-lettered after a terminal parse failure (no escalation tier)",
["reason"], # reason: timeout | oom | error
["reason"], # reason: timeout | oom | error | oversize
)
# Documents dropped after exhausting in-process indexing retries (the scanner
@@ -806,7 +806,8 @@ def record_document_dead_lettered(reason: str) -> None:
Args:
reason: ``timeout`` | ``oom`` | ``error`` (the terminal parse failure
reason carried from the isolated worker).
reason carried from the isolated worker) or ``oversize`` (rejected by
the pre-parse size guard, which no tier can ever parse).
"""
document_dead_lettered_total.labels(reason=reason).inc()