docs(vector): document oversize dead-letter reason and failure-mode comments

Round-4 review nits on PR #920 (none blocking):
- record_document_dead_lettered: enumerate the oversize reason (added this PR)
  alongside timeout/oom/error in the docstring + counter comment.
- Note the clear-dead-letter-before-upsert ordering implication (a transient
  upsert failure re-parses once, never a silent drop).
- Clarify the orphan sweep's kept counter for tenant-wide dead-letter markers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-17 19:38:12 +02:00
co-authored by Claude Opus 4.8
parent a7f7461716
commit 114af7bf12
3 changed files with 8 additions and 2 deletions
+3
View File
@@ -1615,6 +1615,9 @@ async def _index_document(
# escalation tier finally parsed it) so it isn't left behind. Only files are
# ever dead-lettered, and only with a non-empty etag (is_dead_lettered
# early-returns without one), so skip the extra Qdrant round-trip otherwise.
# Cleared before the real-chunk upsert below: if that upsert then fails
# transiently, the document is re-queued and re-parses once on the next scan
# (an extra parse, never a silent drop) -- the safe ordering.
if doc_task.doc_type == "file" and doc_task.etag:
await clear_dead_letter(doc_task.doc_id, doc_task.doc_type)