test(vector): address PR #873 round-3 nits
- Simplify the OCS status guard to `if status and status != "ok"` — falsy (missing/None/"") is tolerated more naturally than the explicit tuple. - Add `test_value_error_from_ocs_failure_returns_none`, covering the OCS-failure ValueError flowing through `_get_enabled_apps_or_none` to the scan-all fallback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
84dfe8a8fc
commit
2e25c2723e
@@ -48,6 +48,19 @@ async def test_returns_none_when_detection_raises(caplog):
|
||||
assert "scanning all apps" in caplog.text
|
||||
|
||||
|
||||
async def test_value_error_from_ocs_failure_returns_none():
|
||||
"""A ValueError (e.g. OCS meta.status=='failure' from get_enabled_apps)
|
||||
routes through the scan-all fallback like any other exception."""
|
||||
nc_client = AsyncMock()
|
||||
nc_client.get_enabled_apps = AsyncMock(
|
||||
side_effect=ValueError("OCS navigation returned status='failure'")
|
||||
)
|
||||
|
||||
result = await _get_enabled_apps_or_none(nc_client, "alice", scan_id=1234)
|
||||
|
||||
assert result is None
|
||||
|
||||
|
||||
def test_none_set_enables_every_app():
|
||||
"""A None set means detection failed, so every app must be scanned."""
|
||||
assert _app_enabled("news", None) is True
|
||||
|
||||
Reference in New Issue
Block a user