fix: address PR review feedback (round 2)
Bug fixes: - Catch OCSError/HTTPStatusError in all server tools, convert to McpError - Guard update_collective against empty body (raise ValueError) - Use restore_page response data in status message ADR-017 annotation fix: - Distinguish "remove" (reversible association) from "delete" (permanent): remove_tag and deck_remove_label_from_card no longer set destructiveHint - Update annotation test to exclude "remove" from destructive keywords Data model improvements: - Add trashTimestamp field to PageInfo - Create ListTrashedPagesResponse with is_trash context flag - Add collective_id to ListTagsResponse Test robustness: - Read NC credentials from environment variables (not hardcoded) - Filter landing page by parentId == 0 instead of assuming pages[0] Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
3393cd9756
commit
44a27bd9e9
@@ -58,8 +58,9 @@ async def test_destructive_tools_have_correct_annotations(nc_mcp_client: ClientS
|
||||
"""Verify destructive operations are marked correctly."""
|
||||
tools = await nc_mcp_client.list_tools()
|
||||
|
||||
# Known destructive operations
|
||||
destructive_keywords = ["delete", "remove", "revoke"]
|
||||
# Known destructive operations (permanently delete data).
|
||||
# "remove" is excluded — removing associations (labels, tags) is reversible.
|
||||
destructive_keywords = ["delete", "revoke"]
|
||||
|
||||
for tool in tools.tools:
|
||||
has_destructive_keyword = any(
|
||||
|
||||
Reference in New Issue
Block a user