fix(security): require WEBHOOK_SECRET for the Nextcloud webhook receiver
GHSA-8vh3-g2qg-2h2c (CVSS 9.1, CWE-306): POST /webhooks/nextcloud had no
authentication when WEBHOOK_SECRET was unset (the default). The receiver
trusted the attacker-supplied user.uid and fed it to Qdrant, letting an
unauthenticated network caller delete or re-index any user's vector
embeddings.
Webhooks now require WEBHOOK_SECRET end-to-end:
- app.py: the /webhooks/nextcloud route is only mounted when WEBHOOK_SECRET
is set; otherwise it 404s and a startup warning notes vector sync falls
back to the polling scanner.
- webhook_receiver.py: removed the warn-and-accept fallback. No secret -> 503,
missing/invalid bearer -> 401; the payload is never processed unauthenticated.
- webhook_routes.py / api/webhooks.py: webhook_auth_pair() raises
WebhookSecretNotConfigured instead of returning authMethod="none"; both
registration entry points return a clear 503 so no dead unauthenticated
webhooks are created.
Also expose webhooks availability to the Astrolabe UI via GET /api/v1/status
("webhooks_enabled": bool), set WEBHOOK_SECRET on the docker-compose
semantic-search dev services, and update env.sample + ADR-010 / ADR-018 /
webhook-management-guide docs.
Vector sync still works without a secret via the polling scanner.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
a818b49b3f
commit
4fc2b10945
@@ -101,6 +101,9 @@ services:
|
||||
- ENABLE_SEMANTIC_SEARCH=true
|
||||
- VECTOR_SYNC_SCAN_INTERVAL=5
|
||||
- VECTOR_SYNC_PROCESSOR_WORKERS=2
|
||||
# Required to enable the /webhooks/nextcloud receiver (GHSA-8vh3-g2qg-2h2c).
|
||||
# Without it the route is not mounted and vector sync relies on polling.
|
||||
- WEBHOOK_SECRET=${WEBHOOK_SECRET:-dev-webhook-secret-change-me}
|
||||
|
||||
#- LOG_FORMAT=json
|
||||
|
||||
@@ -160,6 +163,9 @@ services:
|
||||
- TOKEN_STORAGE_DB=/app/data/tokens.db
|
||||
|
||||
- ENABLE_SEMANTIC_SEARCH=true
|
||||
# Required to enable the /webhooks/nextcloud receiver (GHSA-8vh3-g2qg-2h2c).
|
||||
# Without it the route is not mounted and vector sync relies on polling.
|
||||
- WEBHOOK_SECRET=${WEBHOOK_SECRET:-dev-webhook-secret-change-me}
|
||||
# Tuned cadence for the multi-user background-sync integration suite,
|
||||
# which provisions a user, creates a note, then waits ~90s for it to be
|
||||
# indexed. Two independent knobs matter here:
|
||||
@@ -307,6 +313,9 @@ services:
|
||||
- ENABLE_SEMANTIC_SEARCH=true
|
||||
- VECTOR_SYNC_SCAN_INTERVAL=60
|
||||
- VECTOR_SYNC_PROCESSOR_WORKERS=1
|
||||
# Required to enable the /webhooks/nextcloud receiver (GHSA-8vh3-g2qg-2h2c).
|
||||
# Without it the route is not mounted and vector sync relies on polling.
|
||||
- WEBHOOK_SECRET=${WEBHOOK_SECRET:-dev-webhook-secret-change-me}
|
||||
|
||||
# Management API allowlist (ADR-018) — matches mcp-multi-user-basic so
|
||||
# the same configure_astrolabe_for_mcp_server fixture (which creates the
|
||||
|
||||
Reference in New Issue
Block a user