fix(security): require WEBHOOK_SECRET for the Nextcloud webhook receiver
GHSA-8vh3-g2qg-2h2c (CVSS 9.1, CWE-306): POST /webhooks/nextcloud had no
authentication when WEBHOOK_SECRET was unset (the default). The receiver
trusted the attacker-supplied user.uid and fed it to Qdrant, letting an
unauthenticated network caller delete or re-index any user's vector
embeddings.
Webhooks now require WEBHOOK_SECRET end-to-end:
- app.py: the /webhooks/nextcloud route is only mounted when WEBHOOK_SECRET
is set; otherwise it 404s and a startup warning notes vector sync falls
back to the polling scanner.
- webhook_receiver.py: removed the warn-and-accept fallback. No secret -> 503,
missing/invalid bearer -> 401; the payload is never processed unauthenticated.
- webhook_routes.py / api/webhooks.py: webhook_auth_pair() raises
WebhookSecretNotConfigured instead of returning authMethod="none"; both
registration entry points return a clear 503 so no dead unauthenticated
webhooks are created.
Also expose webhooks availability to the Astrolabe UI via GET /api/v1/status
("webhooks_enabled": bool), set WEBHOOK_SECRET on the docker-compose
semantic-search dev services, and update env.sample + ADR-010 / ADR-018 /
webhook-management-guide docs.
Vector sync still works without a secret via the polling scanner.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
a818b49b3f
commit
4fc2b10945
@@ -28,7 +28,10 @@ from nextcloud_mcp_server.api.management import (
|
||||
validate_token_and_get_user,
|
||||
)
|
||||
from nextcloud_mcp_server.auth.scope_authorization import ProvisioningRequiredError
|
||||
from nextcloud_mcp_server.auth.webhook_routes import webhook_auth_pair
|
||||
from nextcloud_mcp_server.auth.webhook_routes import (
|
||||
WebhookSecretNotConfigured,
|
||||
webhook_auth_pair,
|
||||
)
|
||||
from nextcloud_mcp_server.client.webhooks import WebhooksClient
|
||||
|
||||
from ..http import nextcloud_httpx_client
|
||||
@@ -217,7 +220,19 @@ async def create_webhook(request: Request) -> JSONResponse:
|
||||
# Inject delivery auth headers when WEBHOOK_SECRET is configured so
|
||||
# that webhook deliveries from Nextcloud back to us are authenticated.
|
||||
webhooks_client = WebhooksClient(client, username)
|
||||
auth_method, auth_data = webhook_auth_pair()
|
||||
try:
|
||||
auth_method, auth_data = webhook_auth_pair()
|
||||
except WebhookSecretNotConfigured as e:
|
||||
logger.warning(
|
||||
"Webhook registration refused for user %s: %s", user_id, e
|
||||
)
|
||||
return JSONResponse(
|
||||
{
|
||||
"error": "Webhooks disabled",
|
||||
"message": str(e),
|
||||
},
|
||||
status_code=503,
|
||||
)
|
||||
webhook_data = await webhooks_client.create_webhook(
|
||||
event=event,
|
||||
uri=uri,
|
||||
|
||||
Reference in New Issue
Block a user