admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): repair multi-user-basic Astrolabe integration suite

Browse Source 
The Astrolabe PHP→Vue settings refactor dropped three stable element ids
(#mcp-enable-background-button, #mcp-revoke-background-button,
#mcp-revoke-background-form) that the multi-user-basic integration suite
drives the background-sync enable/disable/revoke flows through. Their
absence timed out the 5s Playwright locators and failed four tests:

- test_astrolabe_multi_user_background_sync::test_multi_user_astrolabe_background_sync_enablement
- test_astrolabe_multi_user_background_sync::test_revoke_background_sync_access
- test_astrolabe_chunk_context::test_chunk_context_endpoint_uses_app_password
- test_astrolabe_plotly_visualization::test_astrolabe_plotly_visualization_with_basic_auth

(the latter two enable background sync via complete_astrolabe_authorization
before exercising the app-password / indexed-search paths).

Two-part fix:

1. Bump the astrolabe submodule to v0.20.1 (cbcoutinho/astrolabe#116),
   which restores the three element ids on the refactored NcButtons.

2. Defense-in-depth in the test helpers: resolve the enable/revoke buttons
   by their stable id first, falling back to the button's accessible name
   so a future id rename degrades to a slower-but-working lookup instead of
   a hard timeout. Avoids a combined `.or_()` locator, which would
   strict-mode-violate (the id button also matches by text).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-04 22:53:43 +02:00
co-authored by Claude Opus 4.8
parent 09e84783e5
commit 531607a1a1
2 changed files with 63 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files