admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(mail): address PR #935 round-1 review

Browse Source 
- models/mail.py: lowercase `list` generics per CLAUDE.md convention.
- client/mail.py: _ocs_get now inspects ocs.meta.statuscode (re-raises >=400
  as HTTPStatusError carrying the OCS code so callers' 404/403 handling
  applies) and guards response.json() against non-JSON bodies (RequestError).
- Extract the duplicated _format_addresses + content reconstruction into
  vector/mail_content.py, used by both processor.py and context.py (fixes the
  SonarCloud new_duplicated_lines_density gate).
- processor.py: add the missing mail_message Qdrant payload block so the
  computed mail metadata (subject/from/to/cc/date_int/has_attachments/
  account_id/mailbox_id) is actually stored, not dropped.
- Rename the list_messages `filter` param to `search_filter` (avoid shadowing
  builtins.filter); still maps to the OCS `filter` query param.
- Docstring notes: has_more heuristic, attachment content size.
- Tests: OCS meta-failure + non-JSON client paths; initial-sync scanner tests
  (tests/unit/vector/test_scanner_mail.py).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-20 12:31:32 +02:00
co-authored by Claude Opus 4.8
parent 3074622455
commit 62ee3e9f32
8 changed files with 303 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/client/mail/test_mail_api.py
+38 -1
View File
@@ -108,7 +108,7 @@ async def test_list_messages_builds_params(mocker):
client = MailClient(mock_client, "testuser")
messages = await client.list_messages(
10, cursor=42, filter="hello", limit=50, view="threaded"
10, cursor=42, search_filter="hello", limit=50, view="threaded"
)
assert len(messages) == 1
@@ -204,3 +204,40 @@ async def test_empty_data_returns_empty_list(mocker):
client = MailClient(mock_client, "testuser")
assert await client.list_accounts() == []
async def test_ocs_meta_failure_raises_httpstatuserror(mocker):
"""HTTP 200 with an OCS meta failure code is re-raised as HTTPStatusError.
The synthetic response carries the OCS statuscode so callers' 404/403
handling applies (e.g. nc_mail_get_message maps 404 to 'not found').
"""
mock_response = create_mock_response(
status_code=200,
json_data={
"ocs": {
"meta": {"status": "failure", "statuscode": 404, "message": "nope"},
"data": None,
}
},
)
mock_client = mocker.AsyncMock(spec=httpx.AsyncClient)
mocker.patch.object(MailClient, "_make_request", return_value=mock_response)
client = MailClient(mock_client, "testuser")
with pytest.raises(httpx.HTTPStatusError) as excinfo:
await client.get_message(100)
assert excinfo.value.response.status_code == 404
async def test_non_json_response_raises_requesterror(mocker):
"""A non-JSON 200 body (e.g. Mail app absent) raises a RequestError."""
mock_response = create_mock_response(
status_code=200, content=b"<html>not found</html>"
)
mock_client = mocker.AsyncMock(spec=httpx.AsyncClient)
mocker.patch.object(MailClient, "_make_request", return_value=mock_response)
client = MailClient(mock_client, "testuser")
with pytest.raises(httpx.RequestError):
await client.list_accounts()