From 6c7b679b52fc0e55d5274e7cfd163efbf1bb7a3d Mon Sep 17 00:00:00 2001 From: Chris Coutinho Date: Thu, 4 Jun 2026 20:53:36 +0200 Subject: [PATCH] docs: correct ADR-028 aclose() description (PR #851 round 6 nit) LocalTransport.aclose() (added in round 3) closes its owned stream ends; the ADR still described aclose() as a no-op for the memory stream. Update the prose to match the shipped behaviour. Doc-only. Refs: Deck #196 Co-Authored-By: Claude Opus 4.8 (1M context) --- docs/ADR-028-ingest-transport-port.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/ADR-028-ingest-transport-port.md b/docs/ADR-028-ingest-transport-port.md index 544b22c2..c5b87af0 100644 --- a/docs/ADR-028-ingest-transport-port.md +++ b/docs/ADR-028-ingest-transport-port.md @@ -55,9 +55,11 @@ build_transport(settings) -> and the integration conftest's stream-singleton handling working unchanged). - `run_consumers(task_group, spawn_worker, count)` — start the in-process pool; a **no-op** for distributed backends, whose consumer is the external worker. -- `aclose()` — tear down backend-owned resources once on shutdown (closes the - procrastinate connector pool; a no-op for the memory stream, which task-group - cancellation closes). +- `aclose()` — tear down backend-owned resources once on shutdown. + `DistributedTransport` closes the procrastinate connector pool; + `LocalTransport` closes its owned send/receive stream ends (belt-and-suspenders + — task-group cancellation already closes the per-worker clones, and anyio + `aclose` is idempotent). The base default is a no-op. The lifespan supplies a `spawn_worker` closure so the transport never learns about auth modes — the single-user closure binds a shared `nc_client`+username,