admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(astrolabe): use internal URL for OAuth token refresh

Browse Source 
The IdpTokenRefresher was incorrectly using overwrite.cli.url (the
external URL like http://localhost:8080) for internal token refresh
requests. This URL is not accessible from inside Docker containers
since port 8080 is only mapped on the host machine.

Changed getNextcloudBaseUrl() to:
- Always use http://localhost (internal port 80) by default
- Added optional astrolabe_internal_url config for custom setups
- Removed overwrite.cli.url usage (intended for external URLs only)

This fixes 401 errors in Astrolabe semantic search when OAuth tokens
need to be refreshed in containerized deployments.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-16 19:42:54 +01:00
co-authored by Claude Opus 4.5
parent 8c6ae9ff33
commit 79cfb65590
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
third_party/astrolabe/lib/Service/IdpTokenRefresher.php
Vendored
+14 -7
View File
@@ -38,23 +38,30 @@ class IdpTokenRefresher {
/** /**
* Get Nextcloud base URL for constructing internal OIDC endpoint URLs. * Get Nextcloud base URL for constructing internal OIDC endpoint URLs.
* *
* Uses Nextcloud's CLI URL config if set (for non-containerized deployments), * IMPORTANT: This is for INTERNAL server-to-server requests (PHP to local Apache),
* otherwise defaults to http://localhost for container environments. * NOT for external client URLs. We must use the internal container URL, not the
* external URL that browsers see.
* *
* Configuration priority: * Configuration priority:
* 1. overwrite.cli.url - Official Nextcloud system config for CLI operations * 1. astrolabe_internal_url - Explicit internal URL (for custom container setups)
* 2. http://localhost - Default for Docker containers (web server on port 80) * 2. http://localhost - Default for Docker containers (web server on port 80)
* *
* NOTE: We intentionally DO NOT use overwrite.cli.url here because:
* - overwrite.cli.url is the EXTERNAL URL (e.g., http://localhost:8080)
* - External URLs are not accessible from inside the container
* - This method is for internal HTTP requests to the local web server
*
* @return string Base URL for internal requests (e.g., "http://localhost") * @return string Base URL for internal requests (e.g., "http://localhost")
*/ */
private function getNextcloudBaseUrl(): string { private function getNextcloudBaseUrl(): string {
// Check for overwrite.cli.url (used in non-containerized deployments) // Check for explicit internal URL config (for custom container setups)
$cliUrl = $this->config->getSystemValue('overwrite.cli.url', ''); $internalUrl = $this->config->getSystemValue('astrolabe_internal_url', '');
if (!empty($cliUrl)) { if (!empty($internalUrl)) {
return rtrim($cliUrl, '/'); return rtrim($internalUrl, '/');
} }
// Default: container environment with web server on localhost:80 // Default: container environment with web server on localhost:80
// This works because PHP runs inside the same container as Apache
return 'http://localhost'; return 'http://localhost';
} }