From 819484015bd785b29018e65ff07b39e82c41eaa6 Mon Sep 17 00:00:00 2001
From: Jos Poortvliet <jospoortvliet@gmail.com>
Date: Sat, 25 Apr 2026 19:17:23 +0200
Subject: [PATCH] fix(mcpb): address review feedback on manifest and run.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Use SPDX identifier AGPL-3.0-only (consistent with pyproject.toml)
- Add compatibility.platforms: [darwin, linux] — run.sh uses /bin/sh
  and is not compatible with Windows; this surfaces that at install time
  rather than silently failing to launch
- Improve run.sh fallback: use 'command -v uvx' before exec so a missing
  uvx prints a clear error with install instructions instead of a generic
  shell 'not found' message

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 mcpb/manifest.json |  5 ++++-
 mcpb/run.sh        | 13 +++++++++++--
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/mcpb/manifest.json b/mcpb/manifest.json
index fdb140b1..8cd1166c 100644
--- a/mcpb/manifest.json
+++ b/mcpb/manifest.json
@@ -13,7 +13,7 @@
     "url": "https://github.com/cbcoutinho/nextcloud-mcp-server"
   },
   "homepage": "https://github.com/cbcoutinho/nextcloud-mcp-server",
-  "license": "AGPL-3.0",
+  "license": "AGPL-3.0-only",
   "keywords": ["nextcloud", "notes", "calendar", "contacts", "files", "deck"],
   "server": {
     "type": "python",
@@ -28,6 +28,9 @@
       }
     }
   },
+  "compatibility": {
+    "platforms": ["darwin", "linux"]
+  },
   "tools_generated": true,
   "user_config": {
     "nextcloud_host": {
diff --git a/mcpb/run.sh b/mcpb/run.sh
index fc5fc81e..030dffa2 100644
--- a/mcpb/run.sh
+++ b/mcpb/run.sh
@@ -10,5 +10,14 @@ for candidate in \
     fi
 done
 
-# Fall back to whatever is in PATH
-exec uvx nextcloud-mcp-server run --transport stdio
+# Fall back to uvx on PATH if found
+if command -v uvx > /dev/null 2>&1; then
+    exec uvx nextcloud-mcp-server run --transport stdio
+fi
+
+# uvx not found — print actionable error and exit
+echo "Error: 'uvx' was not found in any expected location." >&2
+echo "Install uv (which provides uvx) from: https://docs.astral.sh/uv/getting-started/installation/" >&2
+echo "  macOS/Linux: curl -LsSf https://astral.sh/uv/install.sh | sh" >&2
+echo "  Homebrew:    brew install uv" >&2
+exit 1