fix(auth): address PR #757 review feedback

- Branch the ProvisioningRequiredError message on the elicit result so a
  user who acknowledged the prompt isn't told to call
  nc_auth_provision_access (which would loop an LLM that just confirmed
  via elicitation). Other paths keep the existing instruction.
- Convert present_login_url's f-string logger.warning to lazy %s, matching
  present_provisioning_required and the repo's lazy-logging preference.
- Add a test for NEXTCLOUD_PUBLIC_ISSUER_URL trailing-slash normalization.
- Strengthen the decorator-elicits test: split into the "accepted" and
  "message_only" branches so the error-message change is regression-tested.

Refs: cbcoutinho/nextcloud-mcp-server#757#issuecomment-4363552487

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

nextcloud_mcp_server/auth/elicitation.py

@@ -115,8 +115,9 @@ async def present_login_url(
         return "message_only"
     except Exception as e:
         logger.warning(
-            f"Elicitation failed unexpectedly ({type(e).__name__}: {e}), "
+            "Elicitation failed unexpectedly (%s: %s), falling back to message",
-            "falling back to message"
+            type(e).__name__,
+            e,
         )
         return "message_only"
 

nextcloud_mcp_server/auth/scope_authorization.py

@@ -159,13 +159,27 @@ def require_scopes(*required_scopes: str):
                             present_provisioning_required,
                         )
 
-                        await present_provisioning_required(ctx)
+                        elicit_result = await present_provisioning_required(ctx)
 
-                        error_msg = (
+                        # Always raise — the decorator can't safely re-check
-                            f"Access denied to {func_name}: "
+                        # stored scopes mid-call (TTL cache, plus the LFv2
-                            f"Nextcloud access not provisioned. "
+                        # poller may still be running). Only the message
-                            f"Please call 'nc_auth_provision_access' first."
+                        # changes so an LLM that just acknowledged the
-                        )
+                        # elicitation isn't told to call the auth tool
+                        # again (which would loop).
+                        if elicit_result == "accepted":
+                            error_msg = (
+                                f"Access denied to {func_name}: Nextcloud "
+                                f"access was not provisioned at the time of "
+                                f"this call. If you just completed "
+                                f"provisioning, please retry the request."
+                            )
+                        else:
+                            error_msg = (
+                                f"Access denied to {func_name}: "
+                                f"Nextcloud access not provisioned. "
+                                f"Please call 'nc_auth_provision_access' first."
+                            )
                         logger.warning(error_msg)
                         raise ProvisioningRequiredError(error_msg)
 

tests/unit/test_elicitation.py

@@ -31,6 +31,15 @@ def test_astrolabe_settings_url_prefers_public_issuer(monkeypatch):
     )
 
 
+def test_astrolabe_settings_url_strips_trailing_slash_from_public_issuer(monkeypatch):
+    """Trailing slash on NEXTCLOUD_PUBLIC_ISSUER_URL is normalized."""
+    monkeypatch.setenv("NEXTCLOUD_PUBLIC_ISSUER_URL", "https://nc.example.com/")
+
+    assert (
+        _astrolabe_settings_url() == f"https://nc.example.com{ASTROLABE_SETTINGS_PATH}"
+    )
+
+
 def test_astrolabe_settings_url_falls_back_to_host(monkeypatch):
     """When only NEXTCLOUD_HOST is set, use it (and strip a trailing slash)."""
     monkeypatch.setenv("NEXTCLOUD_HOST", "https://only-host.example.com/")

tests/unit/test_scope_authorization_stored.py

@@ -112,14 +112,12 @@ def _make_login_flow_ctx() -> MagicMock:
     return ctx
 
 
-async def test_decorator_elicits_before_raising_when_app_password_missing():
+async def test_decorator_elicits_and_uses_retry_message_when_user_accepts():
-    """When no app password is stored, the decorator must elicit a clickable
+    """When the elicit returns "accepted" the raised error must tell the user
-    Astrolabe / Login-Flow-v2 prompt to the client *before* raising
+    to retry — *not* "call nc_auth_provision_access". The latter would loop
-    ProvisioningRequiredError.
+    an LLM that just acknowledged the elicitation prompt.
 
-    Why: an LLM-only error message ("call nc_auth_provision_access") is
+    See PR #757 review feedback (cbcoutinho/nextcloud-mcp-server#757).
-    unfriendly to humans whose MCP client supports elicitation. See
-    cbcoutinho/nextcloud-mcp-server#752.
     """
     ctx = _make_login_flow_ctx()
 
@@ -147,11 +145,55 @@ async def test_decorator_elicits_before_raising_when_app_password_missing():
             "nextcloud_mcp_server.auth.elicitation.present_provisioning_required",
             elicit_mock,
         ),
-        pytest.raises(ProvisioningRequiredError),
+        pytest.raises(ProvisioningRequiredError) as exc_info,
     ):
         await fake_tool_missing_pwd(ctx=ctx)
 
     elicit_mock.assert_awaited_once_with(ctx)
+    msg = str(exc_info.value)
+    assert "retry the request" in msg
+    assert "nc_auth_provision_access" not in msg
+
+
+async def test_decorator_uses_legacy_message_when_elicitation_unsupported():
+    """When the elicit helper returns "message_only" (client lacks elicit
+    support), the raised error must keep the existing
+    "call nc_auth_provision_access" instruction so an agent has something
+    actionable. Mirrors the "accepted" case but for the fallback branch."""
+    ctx = _make_login_flow_ctx()
+
+    @require_scopes("notes.read")
+    async def fake_tool_missing_pwd_no_elicit(ctx: Context):  # noqa: ARG001
+        return "ok"
+
+    fake_settings = SimpleNamespace(enable_login_flow=True)
+    elicit_mock = AsyncMock(return_value="message_only")
+
+    with (
+        patch(
+            "nextcloud_mcp_server.auth.scope_authorization.get_settings",
+            return_value=fake_settings,
+        ),
+        patch(
+            "nextcloud_mcp_server.auth.scope_authorization._get_stored_scopes",
+            return_value=None,
+        ),
+        patch(
+            "nextcloud_mcp_server.auth.token_utils.extract_user_id_from_token",
+            return_value="alice",
+        ),
+        patch(
+            "nextcloud_mcp_server.auth.elicitation.present_provisioning_required",
+            elicit_mock,
+        ),
+        pytest.raises(ProvisioningRequiredError) as exc_info,
+    ):
+        await fake_tool_missing_pwd_no_elicit(ctx=ctx)
+
+    elicit_mock.assert_awaited_once_with(ctx)
+    msg = str(exc_info.value)
+    assert "nc_auth_provision_access" in msg
+    assert "retry the request" not in msg
 
 
 async def test_decorator_does_not_elicit_when_scopes_only_partially_missing():