From 874c7c109bd86810adb60566b0e8a01e82cee39c Mon Sep 17 00:00:00 2001 From: Chris Coutinho Date: Sun, 31 May 2026 21:38:14 +0200 Subject: [PATCH] fix: stop S7632 flagging NOSONAR mentioned in prose comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SonarCloud's python:S7632 parses the literal ``# NOSONAR`` token wherever it appears — including inside explanatory comments that *quote* the directive — and treats the following text as a malformed suppression. The actual bare ``# NOSONAR`` suppression lines are fine; the flagged lines were the prose comments describing them. Reword those comments to drop the inner ``#`` so the analyzer no longer sees a directive. Co-Authored-By: Claude Opus 4.8 (1M context) --- nextcloud_mcp_server/embedding/gateway_client.py | 4 ++-- nextcloud_mcp_server/vector/queue/nats.py | 6 +++--- nextcloud_mcp_server/vector/queue/postgres.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/nextcloud_mcp_server/embedding/gateway_client.py b/nextcloud_mcp_server/embedding/gateway_client.py index b63461b6..2d729b7c 100644 --- a/nextcloud_mcp_server/embedding/gateway_client.py +++ b/nextcloud_mcp_server/embedding/gateway_client.py @@ -122,8 +122,8 @@ class GatewayProvider(OpenAIProvider): # AsyncOpenAI rejects an empty key; use a non-secret placeholder when # the gateway is unauthenticated. When a token provider is configured, # the real Bearer is set on the client before each request. The bare - # ``# NOSONAR`` silences the hard-coded-credential hotspot — this is a - # public placeholder string, not a secret. + # suppression marker below silences the hard-coded-credential hotspot — + # this is a public placeholder string, not a secret. super().__init__( api_key=_UNAUTHENTICATED_PLACEHOLDER, # NOSONAR base_url=base_url, diff --git a/nextcloud_mcp_server/vector/queue/nats.py b/nextcloud_mcp_server/vector/queue/nats.py index f0675f4a..c87fdfdd 100644 --- a/nextcloud_mcp_server/vector/queue/nats.py +++ b/nextcloud_mcp_server/vector/queue/nats.py @@ -156,9 +156,9 @@ class NatsTaskProducer: ) -> None: return None - # The bare ``# NOSONAR`` silences ``python:S7503`` (async method without - # await): ``async def`` is required by the TaskProducer protocol, but this - # handle close is a genuine no-op. + # The bare suppression marker silences S7503 (async method without await): + # ``async def`` is required by the TaskProducer protocol, but this handle + # close is a genuine no-op. async def aclose(self) -> None: # NOSONAR # Per-handle close (e.g. a per-user scanner clone exiting). The bus # connection is shared and owned by the lifespan, so this is a no-op; diff --git a/nextcloud_mcp_server/vector/queue/postgres.py b/nextcloud_mcp_server/vector/queue/postgres.py index d974fff9..dc15fc27 100644 --- a/nextcloud_mcp_server/vector/queue/postgres.py +++ b/nextcloud_mcp_server/vector/queue/postgres.py @@ -45,7 +45,7 @@ class PostgresTaskProducer: ) -> None: # pragma: no cover return None - # Bare ``# NOSONAR`` silences ``python:S7503`` (async method without await): + # The bare suppression marker silences S7503 (async method without await): # ``async def`` is required by the TaskProducer protocol; this stub is a # no-op until the Postgres transport lands. async def aclose(self) -> None: # NOSONAR # pragma: no cover