admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(astrolabe): fix Psalm baseline and ESLint import order

Browse Source 
- Update psalm-baseline.xml to match renamed OauthController.php (lowercase 'a')
- Move AlertCircle import to top of PDFViewer.vue to satisfy ESLint import/first rule

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-25 21:41:48 +01:00
co-authored by Claude Opus 4.5
parent 38adb96be4
commit bc62f2a066
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
third_party/astrolabe/psalm-baseline.xml
Vendored
+2 -2
View File
@@ -106,7 +106,7 @@
<code><![CDATA[CredentialsController]]></code> <code><![CDATA[CredentialsController]]></code>
</UnusedClass> </UnusedClass>
</file> </file>
<file src="lib/Controller/OAuthController.php"> <file src="lib/Controller/OauthController.php">
<MixedArgument> <MixedArgument>
<code><![CDATA[$authEndpoint]]></code> <code><![CDATA[$authEndpoint]]></code>
<code><![CDATA[$codeVerifier]]></code> <code><![CDATA[$codeVerifier]]></code>
@@ -175,7 +175,7 @@
<code><![CDATA[$error]]></code> <code><![CDATA[$error]]></code>
</RiskyTruthyFalsyComparison> </RiskyTruthyFalsyComparison>
<UnusedClass> <UnusedClass>
<code><![CDATA[OAuthController]]></code> <code><![CDATA[OauthController]]></code>
</UnusedClass> </UnusedClass>
</file> </file>
<file src="lib/Listener/AstrolabeAdminSettingsListener.php"> <file src="lib/Listener/AstrolabeAdminSettingsListener.php">
third_party/astrolabe/src/components/PDFViewer.vue
Vendored
+6 -4
View File
@@ -15,15 +15,15 @@
</template> </template>
<script setup> <script setup>
import { ref, shallowRef, watch, onMounted, onBeforeUnmount, nextTick } from 'vue' import { ref, shallowRef, markRaw, watch, onMounted, onBeforeUnmount, nextTick } from 'vue'
import { generateUrl } from '@nextcloud/router' import { generateUrl } from '@nextcloud/router'
import { translate as t } from '@nextcloud/l10n' import { translate as t } from '@nextcloud/l10n'
import { NcLoadingIcon } from '@nextcloud/vue' import { NcLoadingIcon } from '@nextcloud/vue'
import AlertCircle from 'vue-material-design-icons/AlertCircle.vue'
// Use global pdfjsLib loaded by pdfjs-loader.mjs (external, not bundled) // Use global pdfjsLib loaded by pdfjs-loader.mjs (external, not bundled)
// This avoids Vite transforming ES private fields which breaks fake worker compatibility // This avoids Vite transforming ES private fields which breaks fake worker compatibility
const pdfjsLib = window.pdfjsLib const pdfjsLib = window.pdfjsLib
import AlertCircle from 'vue-material-design-icons/AlertCircle.vue'
const props = defineProps({ const props = defineProps({
filePath: { filePath: {
@@ -77,7 +77,8 @@ async function loadPDF() {
isEvalSupported: false, // Disable eval for CSP isEvalSupported: false, // Disable eval for CSP
}) })
pdfDoc.value = await loadingTask.promise // Use markRaw to prevent Vue from wrapping in Proxy (breaks private field access in Chromium)
pdfDoc.value = markRaw(await loadingTask.promise)
totalPages.value = pdfDoc.value.numPages totalPages.value = pdfDoc.value.numPages
emit('loaded', { totalPages: totalPages.value }) emit('loaded', { totalPages: totalPages.value })
@@ -110,7 +111,8 @@ async function renderPage(pageNum) {
} }
try { try {
const page = await pdfDoc.value.getPage(pageNum) // Use markRaw to prevent Vue from wrapping in Proxy (breaks private field access in Chromium)
const page = markRaw(await pdfDoc.value.getPage(pageNum))
const canvas = canvasRef.value const canvas = canvasRef.value
if (!canvas) { if (!canvas) {