fix(astrolabe): resolve CI failures for code quality checks

- Fix PHP CS Fixer issues (single quotes, indentation)
- Add typed property declarations to ApiController
- Add Psalm baseline to suppress 517 pre-existing errors
- Fix workflow name references (astroglobe → astrolabe)

The CI workflow was previously watching a non-existent path and never
ran. After fixing the path trigger, these pre-existing code quality
issues were discovered. The Psalm baseline allows CI to pass while
tracking technical debt for incremental resolution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-17 10:56:36 +01:00
co-authored by Claude Opus 4.5
parent c018268681
commit c4973290a6
6 changed files with 794 additions and 19 deletions
+7 -7
View File
@@ -26,13 +26,13 @@ use Psr\Log\LoggerInterface;
* Handles form submissions and AJAX requests from settings panels.
*/
class ApiController extends Controller {
private $client;
private $userSession;
private $urlGenerator;
private $logger;
private $tokenStorage;
private $config;
private $tokenRefresher;
private McpServerClient $client;
private IUserSession $userSession;
private IURLGenerator $urlGenerator;
private LoggerInterface $logger;
private McpTokenStorage $tokenStorage;
private IConfig $config;
private IdpTokenRefresher $tokenRefresher;
public function __construct(
string $appName,
@@ -112,7 +112,7 @@ class CredentialsController extends Controller {
// Get MCP server URL from system config (set in config.php)
$mcpServerUrl = $this->config->getSystemValue('mcp_server_url', '');
if (empty($mcpServerUrl)) {
$this->logger->warning("MCP server URL not configured, app password stored locally only");
$this->logger->warning('MCP server URL not configured, app password stored locally only');
return new JSONResponse([
'success' => true,
'partial_success' => true,