fix(mail): address PR #935 round-2 review

- server/mail.py: guard nc_mail_get_message against an empty OCS payload so
  MailMessage(**{}) can't raise an uncaught ValidationError (returns a clean
  'not found' instead).
- server/mail.py: cap inlined attachment content at MAX_ATTACHMENT_CONTENT_BYTES
  (5 MiB), replacing oversized bodies with a sentinel so a large attachment
  can't blow up the MCP response.
- client/mail.py: harden the OCS meta statuscode parse against a non-numeric
  value (treat as success) instead of letting int() raise an uncaught
  ValueError.
- scanner.py: log the newest-N cap hit once per (user, mailbox) at info level
  (discoverable without flooding multi-tenant logs on every scan tick).
- tests: add incremental-sync scanner cases (new message queued, reappeared
  message clears grace, deletion after grace expiry).

Deferred (tracked, card #376): include doc_type in the _potentially_deleted
grace-period key — a pre-existing cross-cutting collision the reviewer flagged
as a follow-up, not a blocker.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-20 12:45:47 +02:00
co-authored by Claude Opus 4.8
parent 62ee3e9f32
commit c62ccf3d0d
4 changed files with 150 additions and 5 deletions
+7 -1
View File
@@ -71,7 +71,13 @@ class MailClient(BaseNextcloudClient):
# instead of silently unwrapping data=null.
ocs = body.get("ocs", {}) if isinstance(body, dict) else {}
meta = ocs.get("meta", {})
status_code = int(meta.get("statuscode", 200) or 200)
# statuscode is spec'd as an int, but harden against a non-numeric value
# in a non-spec response rather than letting int() raise ValueError
# (which neither MCP-tool handler catches) — treat it as success.
try:
status_code = int(meta.get("statuscode", 200) or 200)
except (TypeError, ValueError):
status_code = 200
if status_code >= 400:
synthetic = Response(status_code=status_code, request=response.request)
raise HTTPStatusError(