test(integration): address round-7 review — keep RAG assertion live, fix races

- test_no_results_for_unrelated_query: replace pytest.skip with `unrelated =
  ... or 0.0` and fall through. The physics query almost always returns nothing
  on this corpus, so the skip meant the comparison (and the manual-is-indexed
  check) never ran. Treating no-results as score 0.0 keeps the test live and
  vacuously satisfies `0.0 <= relevant`.
- test_sampling: the three limit/threshold/max-tokens tests now gate on a
  representative created note being searchable (search_term + note_id) instead
  of a bare idle signal that can fire before the new notes are enqueued.
- _get_with_retry: only sleep between attempts, not before giving up.
- _search_helpers: log the id/doc_type schema-drift mismatch at WARNING (CI runs
  --log-cli-level=WARN) so it surfaces instead of hiding behind a timeout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-17 23:19:41 +02:00
co-authored by Claude Opus 4.8
parent 4c7c627e51
commit ca313e7271
4 changed files with 29 additions and 16 deletions
@@ -56,7 +56,8 @@ async def _get_with_retry(
logger.warning(
"GET %s failed (attempt %s/%s): %s", url, attempt, max_attempts, e
)
await anyio.sleep(2)
if attempt < max_attempts:
await anyio.sleep(2) # no point sleeping before we give up
assert last_exc is not None # loop ran at least once, so this is set
raise last_exc