admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(search): address review feedback on multi-folder path filter

Browse Source 
- visualization.py: drop the CSV string-split branch. The Astrolabe PHP
  client sends path_prefixes as a JSON array, so only a list is accepted;
  any other shape is ignored rather than comma-split (which would corrupt
  folder names containing commas).
- viz_routes.py: split the path_prefixes query param on newline (a comma
  is a valid POSIX path char; a newline is not) and pass None instead of
  [""] when the param is absent.
- access_filter.py: widen build_base_filter_conditions' path_prefixes to
  Iterable[str] for consistency with normalize_path_prefixes.
- ADR-027: document the newline delimiter (frontend/viz route) and JSON
  array (PHP->MCP body), and the PHP-side cap on list width.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-03 13:03:42 +02:00
co-authored by Claude Opus 4.8
parent de6c4b360d
commit cd243ed6c3
4 changed files with 24 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nextcloud_mcp_server/api/visualization.py
+10 -18
View File
@@ -231,17 +231,13 @@ async def unified_search(request: Request) -> JSONResponse:
# ADR-027 Phase 2 path filter (files only); blank ⇒ no filter. Accept a
# path_prefixes list (multi-folder) alongside the legacy single
# path_prefix; normalize drops blanks and de-dupes.
# path_prefixes arrives as a JSON array (the Astrolabe PHP client sends
# a list); any other shape is ignored rather than guessed at. The legacy
# single path_prefix is folded in by normalize_path_prefixes.
_path_prefixes_raw = body.get("path_prefixes")
if isinstance(_path_prefixes_raw, list):
_path_prefixes_list = _path_prefixes_raw
elif isinstance(_path_prefixes_raw, str):
_path_prefixes_list = _path_prefixes_raw.split(",")
else:
# Ignore any other JSON shape (number, object, null) rather than
# blowing up on .split — the legacy path_prefix still applies.
_path_prefixes_list = []
path_prefixes = normalize_path_prefixes(
body.get("path_prefix"), _path_prefixes_list
body.get("path_prefix"),
_path_prefixes_raw if isinstance(_path_prefixes_raw, list) else None,
)
if not query:
@@ -459,17 +455,13 @@ async def vector_search(request: Request) -> JSONResponse:
# ADR-027 Phase 2 path filter (files only); blank ⇒ no filter. Accept a
# path_prefixes list (multi-folder) alongside the legacy single
# path_prefix; normalize drops blanks and de-dupes.
# path_prefixes arrives as a JSON array (the Astrolabe PHP client sends
# a list); any other shape is ignored rather than guessed at. The legacy
# single path_prefix is folded in by normalize_path_prefixes.
_path_prefixes_raw = body.get("path_prefixes")
if isinstance(_path_prefixes_raw, list):
_path_prefixes_list = _path_prefixes_raw
elif isinstance(_path_prefixes_raw, str):
_path_prefixes_list = _path_prefixes_raw.split(",")
else:
# Ignore any other JSON shape (number, object, null) rather than
# blowing up on .split — the legacy path_prefix still applies.
_path_prefixes_list = []
path_prefixes = normalize_path_prefixes(
body.get("path_prefix"), _path_prefixes_list
body.get("path_prefix"),
_path_prefixes_raw if isinstance(_path_prefixes_raw, list) else None,
)
# ADR-027 modified-date range filter. Accepts RFC 3339 / ISO 8601
# datetimes or Unix seconds; normalized to int Unix seconds. None ⇒ open.