fix(auth): address PR #757 round-3 review feedback
Three review items from the third-round review on PR #757:
- scope_authorization: split the combined logger.warning(error_msg) in
the require_scopes decorator's missing-app-password branch into two
lazy %-style logger calls (one per branch), keeping the f-string
error_msg for the exception only. The else branch also logs the
elicit_result for diagnostics. Bypassing lazy %-interpolation in
security-sensitive code formatted the message regardless of log level
and matched the repo-wide lazy-logging preference; the new code now
conforms.
- config + browser_oauth_routes: wire COOKIE_SECURE through Settings
(cookie_secure: bool | None = None) so _should_use_secure_cookies()
reads it via get_settings() rather than os.getenv. Completes the
consolidation pass that touched this file in commit 7464340 and
removes the last raw os.getenv from browser_oauth_routes.py
(import os dropped). Dynaconf auto-coerces "true"/"false" → bool;
"1"/"0" arrive as int and are normalised by an explicit bool() at
the consumer.
- elicitation: clarify the _astrolabe_settings_url docstring to call
out that the empty-string case is also a None-return path (matches
the existing `if not base:` guard).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
f31d0544b7
commit
ce80a36877
@@ -46,9 +46,10 @@ def _astrolabe_settings_url() -> str | None:
|
||||
|
||||
Prefers ``nextcloud_public_issuer_url`` (the browser-reachable public URL)
|
||||
over ``nextcloud_host`` (which may be an internal hostname in Docker
|
||||
deployments). Returns None if neither is set, or if the configured base
|
||||
URL is missing an http:// or https:// scheme — in the latter case the
|
||||
caller renders the tool-only fallback message instead of a broken link.
|
||||
deployments). Returns None if neither is set (or set to the empty
|
||||
string), or if the configured base URL is missing an http:// or
|
||||
https:// scheme — in the latter case the caller renders the tool-only
|
||||
fallback message instead of a broken link.
|
||||
"""
|
||||
settings = get_settings()
|
||||
base = (
|
||||
|
||||
Reference in New Issue
Block a user