fix(vector-sync): address round-5 review — partial-failure signal, markers

- purge route: include a "failed" key in the 200 body listing requested doc
  types that were not purged, so Astrolabe knows consent isn't yet enforced
  for them (scanner backstop still catches up)
- tests: add @pytest.mark.unit / module-level pytestmark to the new test
  modules so they run under `pytest -m unit`; add a partial-failure route test
- capabilities: comment why the cache is keyed per-user despite a global value
- semantic/scanner: doc/comment clarifications (sorted-order, eviction timing)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-06-16 01:47:44 +02:00
co-authored by Claude Opus 4.8
parent b0751102d7
commit d0db530ac9
10 changed files with 64 additions and 7 deletions
@@ -168,6 +168,26 @@ def test_admin_purge_happy_path(mocker):
purge.assert_awaited_once_with(["file"])
def test_partial_failure_reports_failed_types(mocker):
# purge_doc_types returns only the succeeded types; the route must tell the
# caller which requested types were NOT purged.
_patch_token(mocker, "admin")
_patch_basic_auth(mocker, "admin")
_patch_outbound_client(mocker)
_patch_groups(mocker, ["admin"])
_patch_purge(mocker, {"file": 3}) # "note" failed
client = TestClient(_build_app())
resp = client.post(
"/api/v1/vector-sync/purge", json={"doc_types": ["file", "note"]}
)
assert resp.status_code == 200
body = resp.json()
assert body["purged"] == {"file": 3}
assert body["failed"] == ["note"]
def test_bad_request_when_body_not_object(mocker):
# A valid JSON non-object (e.g. a list) must 400, not 500.
_patch_token(mocker)