fix(auth): address PR #758 round-5 medium/low review

Three findings from the latest review on #758 (1 medium, 2 low):

Medium:
- browser_oauth_routes.oauth_logout: move delete_browser_session into a
  finally block so an error from delete_refresh_token can no longer leave
  an orphan browser_sessions row. The orphan was not exploitable
  (SessionAuthBackend rejects sessions without a live refresh token), but
  it lingered until the hourly cleanup cron — a correctness gap. New
  regression test pins the fix.

Low:
- oauth_callback_nextcloud: drop redundant ``or None`` from
  ``expected_nonce=nonce``. ``nonce`` is already ``str | None`` and
  ``secrets.token_urlsafe`` never produces an empty string, so the
  coercion was a no-op that could mislead future readers into thinking
  empty-string was a valid skip-the-check path.
- storage.RefreshTokenStorage.initialize: fail fast at startup when
  SQLite < 3.35, since ``DELETE ... RETURNING`` (used in
  ``delete_browser_session``) needs that minimum. Ubuntu 20.04 ships
  3.31 and would otherwise hit OperationalError on every logout.
  Prerequisite also documented in docs/installation.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-05-03 01:37:38 +02:00
co-authored by Claude Opus 4.7
parent b696541918
commit e2955e8246
5 changed files with 86 additions and 5 deletions
+50
View File
@@ -182,6 +182,56 @@ async def test_logout_swallows_storage_errors(storage):
assert response.status_code == 302 # logout still succeeds
async def test_logout_deletes_session_when_refresh_token_delete_fails(storage):
"""Browser session row must be removed even if delete_refresh_token raises.
Pins PR #758 round-5 review medium 1: previously the two deletes lived
in the same try-block, so an error on ``delete_refresh_token`` left an
orphan ``browser_sessions`` row that lingered until the cleanup cron.
"""
await storage.create_browser_session(session_id="sid-orphan", user_id="dave")
await storage.store_refresh_token(
user_id="dave", refresh_token="rt-dave", flow_type="browser"
)
real_delete_refresh_token = storage.delete_refresh_token
real_delete_browser_session = storage.delete_browser_session
storage.delete_refresh_token = AsyncMock(side_effect=RuntimeError("boom"))
delete_browser_session_calls: list[str] = []
async def tracking_delete_browser_session(session_id: str) -> bool:
delete_browser_session_calls.append(session_id)
return await real_delete_browser_session(session_id)
storage.delete_browser_session = tracking_delete_browser_session
request = _build_request(
cookie="sid-orphan",
oauth_context={
"storage": storage,
"config": {
"mcp_server_url": "https://mcp.example.com",
"discovery_url": None,
},
},
)
try:
response = await oauth_logout(request)
finally:
storage.delete_refresh_token = real_delete_refresh_token
storage.delete_browser_session = real_delete_browser_session
assert response.status_code == 302
assert delete_browser_session_calls == ["sid-orphan"], (
"delete_browser_session must run even after delete_refresh_token raised"
)
assert await storage.get_browser_session_user("sid-orphan") is None, (
"browser_sessions row must be gone — finally branch failed to fire"
)
async def test_logout_blocks_cross_origin_post(storage):
"""POST from a foreign Origin must be rejected with 403 (PR #758 finding 5)."""
await storage.create_browser_session(session_id="sid-X", user_id="alice")