fix(infra): address PR review feedback on tf modules
Deployer role: - Add servicediscovery actions; module always creates Cloud Map namespace and service so the policy must grant CreatePrivateDnsNamespace etc. - Make Route53 + ACM permissions unconditional. The server module always issues an ACM cert and writes Route53 records (no CloudFront default-cert path exists), so gating these on route53_zone_ids was broken. Split Route53 into hosted-zone management (always) plus record-set mutation (scoped to caller-supplied zones, falls back to *). - Remove unused cloudfront:* statement; no CloudFront resources in module. - Replace acm:* wildcard with explicit cert-management action set. Server module: - qdrant_image_tag is now nullable with default null and validated against use_external_qdrant, so external-qdrant callers can omit it instead of passing a sentinel "unused" value. - task_role_arn and efs_id outputs marked sensitive; qdrant_dns_name returns null when use_external_qdrant = true. - ALB SG now has matching IPv6 egress rule (was v4-only). - nextcloud_url validates the https:// scheme. - random_pet.subdomain keeper includes zone_name so a zone migration that preserves zone_id still triggers regeneration. - Pin required_version >= 1.9 on both modules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
ccf4b91bf9
commit
e4c552cd19
@@ -22,6 +22,11 @@ variable "private_subnet_ids" {
|
||||
variable "nextcloud_url" {
|
||||
description = "Public URL of the Nextcloud instance the MCP server pairs with (e.g., https://cloud.example.com). Used to advertise the OIDC discovery endpoint via /api/v1/status so the astrolabe Nextcloud app can discover Nextcloud's oidc_provider as the IdP instead of falling back to http://localhost."
|
||||
type = string
|
||||
|
||||
validation {
|
||||
condition = startswith(var.nextcloud_url, "https://")
|
||||
error_message = "nextcloud_url must include the https:// scheme; OIDC discovery is composed by appending /.well-known/openid-configuration."
|
||||
}
|
||||
}
|
||||
|
||||
variable "zone_id" {
|
||||
@@ -117,8 +122,15 @@ variable "qdrant_collection" {
|
||||
}
|
||||
|
||||
variable "qdrant_image_tag" {
|
||||
description = "Qdrant container image tag (e.g., v1.15.0). Pin to a specific release; avoid :latest. Unused when use_external_qdrant = true."
|
||||
description = "Qdrant container image tag (e.g., v1.15.0). Pin to a specific release; avoid :latest. Required only when use_external_qdrant = false; omit (or pass null) when use_external_qdrant = true."
|
||||
type = string
|
||||
nullable = true
|
||||
default = null
|
||||
|
||||
validation {
|
||||
condition = var.use_external_qdrant || var.qdrant_image_tag != null
|
||||
error_message = "qdrant_image_tag is required when use_external_qdrant = false."
|
||||
}
|
||||
}
|
||||
|
||||
variable "use_external_qdrant" {
|
||||
|
||||
Reference in New Issue
Block a user