fix(auth): invalidate scope cache on web/REST provisioning paths
The elicitation flow points users to the Astrolabe web route or the BasicAuth REST endpoint to provision their app password. Both paths stored the password without clearing the in-process scope cache, so a user who provisioned through them would keep hitting ProvisioningRequiredError for up to _SCOPE_CACHE_TTL (5 min) afterwards. Add invalidate_scope_cache(user_id) to both write-paths (matching the existing pattern in nc_auth_check_status), correct the now-misleading comment in scope_authorization.py to name all three invalidation paths, and add a one-line hint above the first elicitation patch in the test file so future authors don't "fix" the patch target to the wrong module. Addresses PR #757 round-3 review feedback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
7464340763
commit
f31d0544b7
@@ -21,6 +21,7 @@ from starlette.requests import Request
|
||||
from starlette.responses import JSONResponse
|
||||
|
||||
from nextcloud_mcp_server.api.management import _sanitize_error_for_client
|
||||
from nextcloud_mcp_server.auth.scope_authorization import invalidate_scope_cache
|
||||
from nextcloud_mcp_server.auth.storage import RefreshTokenStorage
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
@@ -305,6 +306,7 @@ async def provision_app_password(request: Request) -> JSONResponse:
|
||||
await storage.store_app_password_with_scopes(
|
||||
username, app_password, scopes=scopes, username=nc_username
|
||||
)
|
||||
invalidate_scope_cache(username)
|
||||
|
||||
_record_rate_limit_attempt(path_user_id, success=True)
|
||||
logger.info(f"Provisioned app password for user: {username}")
|
||||
|
||||
Reference in New Issue
Block a user