fix(auth): invalidate scope cache on web/REST provisioning paths
The elicitation flow points users to the Astrolabe web route or the BasicAuth REST endpoint to provision their app password. Both paths stored the password without clearing the in-process scope cache, so a user who provisioned through them would keep hitting ProvisioningRequiredError for up to _SCOPE_CACHE_TTL (5 min) afterwards. Add invalidate_scope_cache(user_id) to both write-paths (matching the existing pattern in nc_auth_check_status), correct the now-misleading comment in scope_authorization.py to name all three invalidation paths, and add a one-line hint above the first elicitation patch in the test file so future authors don't "fix" the patch target to the wrong module. Addresses PR #757 round-3 review feedback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
7464340763
commit
f31d0544b7
@@ -141,6 +141,9 @@ async def test_decorator_elicits_and_uses_retry_message_when_user_accepts():
|
||||
"nextcloud_mcp_server.auth.token_utils.extract_user_id_from_token",
|
||||
return_value="alice",
|
||||
),
|
||||
# Patch the elicitation module (not scope_authorization) because the
|
||||
# decorator does a local import of present_provisioning_required to
|
||||
# avoid a circular import, so the name is re-fetched at call-time.
|
||||
patch(
|
||||
"nextcloud_mcp_server.auth.elicitation.present_provisioning_required",
|
||||
elicit_mock,
|
||||
|
||||
Reference in New Issue
Block a user