Chris CoutinhoandClaude Opus 4.8 bb08245c91 fix(ocr): round-5 review nits — empty-pages failure, comments, test cleanup ...

Round 5 review (PR #910), all nits, no blockers:
- _result_from_success: a succeeded job with `pages=[]` (empty list, not just a
  missing key) is now a per-document failure ("no pages returned") instead of a
  silent 0-chunk success. Test added.
- Comment the deadline-expiry path: the gateway-side job isn't cancelled (no
  cancel endpoint at this layer) — it's reaped by the gateway file purge; we just
  stop polling it.
- Drop the vestigial status="pending" from the BatchOcrJob test fakes (the column
  was removed in round 4; BatchPollResult.status fakes are untouched).

1653 unit tests pass; ruff + ty green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-15 11:12:42 +02:00

..

admin

fix: address PR #814 review + SonarCloud gate

2026-05-29 18:36:42 +02:00

alembic

fix(ocr): round-4 review — defensive poll + drop dead tracking columns

2026-06-15 11:04:03 +02:00

api

fix(security): require WEBHOOK_SECRET for the Nextcloud webhook receiver

2026-06-14 18:18:34 +02:00

auth

fix(security): require WEBHOOK_SECRET for the Nextcloud webhook receiver

2026-06-14 18:18:34 +02:00

client

Merge pull request #832 from Janhouse/fix/830-external-calendars

2026-06-15 06:34:16 +02:00

controllers

fix: return all notes when search query is empty

2025-11-13 21:57:14 +01:00

document_processors

fix(ocr): round-5 review nits — empty-pages failure, comments, test cleanup

2026-06-15 11:12:42 +02:00

embedding

fix(ocr): round-5 review nits — empty-pages failure, comments, test cleanup

2026-06-15 11:12:42 +02:00

models

Merge pull request #832 from Janhouse/fix/830-external-calendars

2026-06-15 06:34:16 +02:00

observability

feat(ingest): record suppressed OCR escalations (what-if-OCR signal)

2026-06-13 15:16:03 +02:00

providers

test(providers): Mistral batch retry + retry-log detail + comment (#893 r4)

2026-06-11 06:45:56 +02:00

search

refactor(search): structural per-instance query side-channel; doc search billing gap

2026-06-08 13:52:51 +02:00

server

feat(ingest): per-tier escalation via procrastinate queue-hop

2026-06-13 13:22:18 +02:00

usage

feat(usage): rename metrics → tokens_embedded/pages_embedded + export token cost to Prometheus

2026-06-08 13:17:53 +02:00

utils

feat(search): ADR-027 Phase 1 — modified-date range filter

2026-06-03 00:35:20 +02:00

vector

fix(ocr): round-4 review — defensive poll + drop dead tracking columns

2026-06-15 11:04:03 +02:00

__init__.py

Initial commit

2025-05-04 23:24:55 +02:00

acl_hash.py

feat: add opt-in MCP decomposition hook points (design §10)

2026-05-29 13:13:25 +02:00

app.py

fix(security): require WEBHOOK_SECRET for the Nextcloud webhook receiver

2026-06-14 18:18:34 +02:00

canonical.py

feat: replace NATS ingest with procrastinate Postgres queue (#183)

2026-06-03 04:11:11 +02:00

cli.py

fix(ingest): address review round 1 (reclaim queue + tests)

2026-06-13 13:34:03 +02:00

config_validators.py

chore: round-4 polish + standardize on module-level loggers

2026-06-03 15:44:59 +02:00

config.py

fix(ocr): round-2 review — lazy store lock, mode enum normalization, type hints

2026-06-15 10:45:10 +02:00

context.py

fix(auth): authenticate stored app passwords with loginName, not UID

2026-05-31 21:34:05 +02:00

http.py

feat: add self-signed SSL certificate support for Nextcloud connections

2026-02-16 09:21:21 +01:00

migrations.py

fix(storage): address PR #798 round-4 review (NOSONAR syntax + pg_advisory_lock + engine dispose + nits)

2026-05-17 09:25:42 +02:00

stdio.py

fix: address third round of review feedback

2026-04-07 23:59:39 +02:00