
Chris CoutinhoandClaude Opus 4.5
1cc460b0d8
fix(astrolabe): Address reviewer feedback for hybrid mode
Addresses code review feedback:
Personal.php:
- Consolidate template variables to use camelCase consistently
- Remove duplicate snake_case variables (auth_mode, supports_app_passwords)
- Add oauthUrl to standard OAuth mode parameters (fixes fallback issue)
- Add requesttoken for CSRF protection
personal.php (template):
- Use null coalescing for safe variable access
- Reuse computed $isHybridMode variable instead of duplicate check
- Remove complex fallback URL logic (oauthUrl now always provided)
IdpTokenRefresher.php:
- Use Nextcloud's overwrite.cli.url config when available
- Fall back to http://localhost for container deployments
- Better supports non-containerized environments
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-16 10:44:52 +01:00
..
2026-01-16 10:44:52 +01:00
2025-11-18 12:17:23 +01:00
2025-12-20 00:52:21 +01:00