Six review items raised; four required code changes (#3, #4, #5, #6) and two were resolved without code changes (#1 audit-only, #2 informational). * search/verification.py — clarify the granularity asymmetry between the whole-batch fail-open (structural API failure) and the per-item fail-open (single bad stored doc_id). Future readers no longer need to derive why the two paths have different blast radii from the code alone. * models/semantic.py — `dropped_document_count` description now explicitly notes that subtracting it from `verified_chunk_count` is not a meaningful operation, since the two fields count different units (documents vs chunks). Surfaces the unit mismatch where MCP clients actually see it. * server/semantic.py — clarify the per-doc_type over-fetch comment so the N×2 pre-merge Qdrant cost (vs the cross-app branch's 1×2) is explicit rather than implied by "same 2× over-fetch budget". * tests/unit/search/test_verification.py — add four new 429 unit tests (notes/news/files/deck) mirroring the existing 5xx-keeps pattern. Locks in that `_is_definitive_404_or_403` returns False for 429 so a future refactor cannot accidentally treat rate-limit responses as permanent revocations. Audit confirmation for review item #1: all four `WebDAVClient.get_file_info` call sites already handle the new `HTTPStatusError`-on-404 contract (verification.py:156, tests/integration/test_rag.py:139, tests/unit/client/test_webdav.py:153/190). No silent breakage internal to this repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
179 lines
7.0 KiB
Python
179 lines
7.0 KiB
Python
"""Pydantic models for semantic search responses."""
|
|
|
|
from pydantic import BaseModel, Field
|
|
|
|
from .base import BaseResponse
|
|
|
|
|
|
class SemanticSearchResult(BaseModel):
|
|
"""Model for semantic search results with additional metadata."""
|
|
|
|
id: int = Field(
|
|
description=(
|
|
"Document ID. Numeric for all currently indexed types (notes, files, "
|
|
"deck cards, news items). The internal SearchResult.id is typed as "
|
|
"int|str to leave room for future doc types with string identifiers; "
|
|
"the MCP response narrows to int and a future widening here would be "
|
|
"a deliberate, breaking-by-design API change."
|
|
)
|
|
)
|
|
doc_type: str = Field(
|
|
description="Document type (note, calendar_event, deck_card, etc.)"
|
|
)
|
|
title: str = Field(description="Document title")
|
|
category: str = Field(
|
|
default="", description="Document category (notes) or location (calendar)"
|
|
)
|
|
excerpt: str = Field(description="Excerpt from matching chunk")
|
|
score: float = Field(
|
|
description=(
|
|
"Relevance score (≥ 0.0, higher is better). "
|
|
"Score range depends on fusion method: "
|
|
"RRF produces scores in [0.0, 1.0], "
|
|
"DBSF can exceed 1.0 (sum of normalized scores from multiple systems)"
|
|
)
|
|
)
|
|
chunk_index: int = Field(description="Index of matching chunk in document")
|
|
total_chunks: int = Field(description="Total number of chunks in document")
|
|
chunk_start_offset: int | None = Field(
|
|
default=None, description="Character position where chunk starts in document"
|
|
)
|
|
chunk_end_offset: int | None = Field(
|
|
default=None, description="Character position where chunk ends in document"
|
|
)
|
|
page_number: int | None = Field(
|
|
default=None, description="Page number for PDF documents"
|
|
)
|
|
page_count: int | None = Field(
|
|
default=None, description="Total number of pages in PDF document"
|
|
)
|
|
# Context expansion fields (optional, populated when include_context=True)
|
|
has_context_expansion: bool = Field(
|
|
default=False, description="Whether context expansion was performed"
|
|
)
|
|
marked_text: str | None = Field(
|
|
default=None,
|
|
description="Full text with position markers around matched chunk",
|
|
)
|
|
before_context: str | None = Field(
|
|
default=None, description="Text before the matched chunk"
|
|
)
|
|
after_context: str | None = Field(
|
|
default=None, description="Text after the matched chunk"
|
|
)
|
|
has_before_truncation: bool | None = Field(
|
|
default=None, description="Whether before_context was truncated"
|
|
)
|
|
has_after_truncation: bool | None = Field(
|
|
default=None, description="Whether after_context was truncated"
|
|
)
|
|
|
|
|
|
class SemanticSearchResponse(BaseResponse):
|
|
"""Response model for semantic search across all indexed Nextcloud apps."""
|
|
|
|
results: list[SemanticSearchResult] = Field(
|
|
description="Semantic search results with similarity scores"
|
|
)
|
|
query: str = Field(description="The search query used")
|
|
total_found: int = Field(description="Total number of documents found")
|
|
search_method: str = Field(
|
|
default="semantic", description="Search method used (semantic or hybrid)"
|
|
)
|
|
verified_chunk_count: int = Field(
|
|
default=0,
|
|
description=(
|
|
"Number of search result chunks that passed verify-on-read "
|
|
"access checks (ADR-019). Equals len(verified_results) before "
|
|
"trimming to limit. Sized in chunks (result rows), NOT in "
|
|
"unique documents — see dropped_document_count for the "
|
|
"per-document counterpart."
|
|
),
|
|
)
|
|
dropped_document_count: int = Field(
|
|
default=0,
|
|
description=(
|
|
"Number of unique (doc_id, doc_type) pairs dropped as ghost "
|
|
"records during verify-on-read (ADR-019). A short result page "
|
|
"(len(results) < limit) combined with a non-zero "
|
|
"dropped_document_count indicates ghost density rather than "
|
|
"scarcity of relevant content. Note: this counter is sized in "
|
|
"unique documents while verified_chunk_count is sized in "
|
|
"chunks — a single document can contribute multiple chunks, "
|
|
"so subtracting dropped_document_count from "
|
|
"verified_chunk_count is NOT a meaningful operation."
|
|
),
|
|
)
|
|
|
|
|
|
class SamplingSearchResponse(BaseResponse):
|
|
"""Response from semantic search with LLM-generated answer via MCP sampling.
|
|
|
|
This response includes both a generated natural language answer (created by
|
|
the MCP client's LLM via sampling) and the source documents used to generate
|
|
that answer. Users can read the answer for quick information and review
|
|
sources for verification and deeper exploration.
|
|
|
|
Attributes:
|
|
query: The original user query
|
|
generated_answer: Natural language answer generated by client's LLM
|
|
sources: List of semantic search results used as context
|
|
total_found: Total number of matching documents found
|
|
search_method: Always "semantic_sampling" for this response type
|
|
model_used: Name of model that generated the answer (e.g., "claude-3-5-sonnet")
|
|
stop_reason: Why generation stopped ("endTurn", "maxTokens", etc.)
|
|
"""
|
|
|
|
query: str = Field(..., description="Original user query")
|
|
generated_answer: str = Field(
|
|
..., description="LLM-generated answer based on retrieved documents"
|
|
)
|
|
sources: list[SemanticSearchResult] = Field(
|
|
default_factory=list,
|
|
description="Source documents with excerpts and relevance scores",
|
|
)
|
|
total_found: int = Field(..., description="Total matching documents")
|
|
search_method: str = Field(
|
|
default="semantic_sampling", description="Search method used"
|
|
)
|
|
model_used: str | None = Field(
|
|
default=None, description="Model that generated the answer"
|
|
)
|
|
stop_reason: str | None = Field(
|
|
default=None, description="Reason generation stopped"
|
|
)
|
|
|
|
|
|
class VectorSyncStatusResponse(BaseResponse):
|
|
"""Response for vector sync status.
|
|
|
|
Provides information about the current state of vector sync,
|
|
including how many documents are indexed and how many are pending.
|
|
|
|
Attributes:
|
|
indexed_count: Number of documents in Qdrant vector database
|
|
pending_count: Number of documents in processing queue
|
|
status: Current sync status ("idle" or "syncing")
|
|
enabled: Whether vector sync is enabled
|
|
"""
|
|
|
|
indexed_count: int = Field(
|
|
default=0, description="Number of documents indexed in vector database"
|
|
)
|
|
pending_count: int = Field(
|
|
default=0, description="Number of documents pending processing"
|
|
)
|
|
status: str = Field(
|
|
default="disabled",
|
|
description='Sync status: "idle", "syncing", or "disabled"',
|
|
)
|
|
enabled: bool = Field(default=False, description="Whether vector sync is enabled")
|
|
|
|
|
|
__all__ = [
|
|
"SemanticSearchResult",
|
|
"SemanticSearchResponse",
|
|
"SamplingSearchResponse",
|
|
"VectorSyncStatusResponse",
|
|
]
|