From a3ca1f3505ef6dd692a10603508e17e744e06d78 Mon Sep 17 00:00:00 2001 From: admin Date: Sun, 14 Jun 2026 21:11:53 +0000 Subject: [PATCH] Ensure success email subject is wired to EMAIL_SUBJECT_SUCCESS and never blank --- scraibe/tasks.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/scraibe/tasks.py b/scraibe/tasks.py index 73ff245..acc4fd8 100644 --- a/scraibe/tasks.py +++ b/scraibe/tasks.py @@ -164,17 +164,13 @@ def send_success_email( Subject is customizable via EMAIL_SUBJECT_SUCCESS. Falls back to a safe default if the env var is missing or blank. """ - subject = _get_subject( - "EMAIL_SUBJECT_SUCCESS", - "ScrAIbe: Your transcript is ready", - ) - - # Ensure subject is never blank - if not subject.strip(): + # Read subject from environment; never allow blank + subject = (os.getenv("EMAIL_SUBJECT_SUCCESS") or "").strip() + if not subject: subject = "ScrAIbe: Your transcript is ready" - logger.warning("EMAIL_SUBJECT_SUCCESS was blank; using default subject.") + logger.info("EMAIL_SUBJECT_SUCCESS not set or blank; using default subject.") else: - logger.info("Using success email subject: %s", subject) + logger.info("Using EMAIL_SUBJECT_SUCCESS: %s", subject) body = ( "Hello,\n\n"