admin/mcp-nextcloud
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(webhooks): use HTTP 428 instead of 412 for unprovisioned users

Browse Source 
428 (Precondition Required, RFC 6585) is the correct semantic — the
request requires the client to complete a prerequisite step (Login Flow
v2 provisioning) before retrying. 412 (Precondition Failed) is for
header-based preconditions like ETags / If-Match.

No behavior change beyond the status code; same JSON payload.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-05-04 00:15:55 +02:00
co-authored by Claude Opus 4.7
parent a0e484d95b
commit b3a7587f1a
3 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/test_webhooks_api_auth.py
+6 -6
View File
@@ -116,7 +116,7 @@ async def test_list_webhooks_uses_basic_auth(mocker):
_assert_basic_auth_not_bearer(factory)
async def test_list_webhooks_returns_412_when_unprovisioned(mocker):
async def test_list_webhooks_returns_428_when_unprovisioned(mocker):
_patch_token_validation(mocker)
mocker.patch(
"nextcloud_mcp_server.api.webhooks.get_basic_auth_for_user",
@@ -126,7 +126,7 @@ async def test_list_webhooks_returns_412_when_unprovisioned(mocker):
client = TestClient(_build_test_app())
resp = client.get("/api/v1/webhooks", headers={"Authorization": "Bearer mcp-token"})
assert resp.status_code == 412
assert resp.status_code == 428
assert resp.json()["error"] == "Provisioning required"
@@ -177,7 +177,7 @@ async def test_create_webhook_validates_required_fields(mocker):
assert resp.status_code == 400
async def test_create_webhook_returns_412_when_unprovisioned(mocker):
async def test_create_webhook_returns_428_when_unprovisioned(mocker):
_patch_token_validation(mocker)
mocker.patch(
"nextcloud_mcp_server.api.webhooks.get_basic_auth_for_user",
@@ -191,7 +191,7 @@ async def test_create_webhook_returns_412_when_unprovisioned(mocker):
json={"event": "X", "uri": "http://x"},
)
assert resp.status_code == 412
assert resp.status_code == 428
assert resp.json()["error"] == "Provisioning required"
@@ -229,7 +229,7 @@ async def test_delete_webhook_rejects_non_integer_id(mocker):
assert resp.status_code == 400
async def test_delete_webhook_returns_412_when_unprovisioned(mocker):
async def test_delete_webhook_returns_428_when_unprovisioned(mocker):
_patch_token_validation(mocker)
mocker.patch(
"nextcloud_mcp_server.api.webhooks.get_basic_auth_for_user",
@@ -242,7 +242,7 @@ async def test_delete_webhook_returns_412_when_unprovisioned(mocker):
headers={"Authorization": "Bearer mcp-token"},
)
assert resp.status_code == 412
assert resp.status_code == 428
assert resp.json()["error"] == "Provisioning required"