mcp-nextcloud/tests/unit/test_processor_drop_reason.py

"""Unit tests for the embed-drop classifier (card 309).

``processor._drop_reason`` maps a terminal indexing failure to a metric label
so the transient backend-pod-rollover causes (connection / timeout) are
alertable on ``astrolabe_vector_ingest_dropped_total`` distinctly from
persistent faults.
"""

import httpx
import pytest

from nextcloud_mcp_server.vector import processor


def _req() -> httpx.Request:
    return httpx.Request("POST", "https://gw/v1/embeddings")


@pytest.mark.unit
def test_httpx_connect_and_timeout_classified():
    assert processor._drop_reason(httpx.ConnectError("refused")) == "connection"
    assert processor._drop_reason(httpx.ReadTimeout("slow")) == "timeout"
    assert processor._drop_reason(httpx.ConnectTimeout("slow")) == "timeout"


@pytest.mark.unit
def test_openai_errors_classified():
    from openai import (
        APIConnectionError,
        APITimeoutError,
        InternalServerError,
        RateLimitError,
    )

    req = _req()
    assert processor._drop_reason(APIConnectionError(request=req)) == "connection"
    assert processor._drop_reason(APITimeoutError(request=req)) == "timeout"
    assert (
        processor._drop_reason(
            RateLimitError("rl", response=httpx.Response(429, request=req), body=None)
        )
        == "rate_limit"
    )
    assert (
        processor._drop_reason(
            InternalServerError(
                "boom", response=httpx.Response(503, request=req), body=None
            )
        )
        == "server"
    )


@pytest.mark.unit
def test_exception_group_unwraps_to_leaf():
    group = BaseExceptionGroup(
        "unhandled errors in a TaskGroup", [httpx.ConnectError("refused")]
    )
    assert processor._drop_reason(group) == "connection"


@pytest.mark.unit
def test_nested_exception_group_descends_to_leaf():
    """A doubly-wrapped group must still classify by its leaf, not 'other'."""
    nested = BaseExceptionGroup(
        "outer", [BaseExceptionGroup("inner", [httpx.ReadTimeout("slow")])]
    )
    assert processor._drop_reason(nested) == "timeout"


@pytest.mark.unit
def test_qdrant_namespace_classified():
    from qdrant_client.http.exceptions import UnexpectedResponse

    exc = UnexpectedResponse(500, "err", b"", headers=httpx.Headers())
    assert processor._drop_reason(exc) == "qdrant"


@pytest.mark.unit
def test_unknown_error_falls_back_to_other():
    assert processor._drop_reason(ValueError("nope")) == "other"


@pytest.mark.unit
async def test_process_document_records_drop_on_exhausted_retries(mocker):
    """Exhausting retries in process_document increments the drop counter with
    the classified reason (and re-raises so the outer handler counts the error)."""
    from nextcloud_mcp_server.vector.scanner import DocumentTask

    doc_task = DocumentTask(
        user_id="alice",
        doc_id="42",
        doc_type="note",
        operation="index",
        modified_at=0,
    )

    mocker.patch.object(
        processor,
        "get_qdrant_client",
        mocker.AsyncMock(return_value=mocker.MagicMock()),
    )
    mocker.patch.object(
        processor, "_index_document", side_effect=httpx.ConnectError("refused")
    )
    rec = mocker.patch.object(processor, "record_ingest_dropped")

    with pytest.raises(httpx.ConnectError):
        await processor.process_document(doc_task, mocker.MagicMock(), max_retries=1)

    rec.assert_called_once_with("connection")


@pytest.mark.unit
async def test_process_document_drops_admin_disabled_index_task(mocker):
    """A near-real-time index task for an admin-disabled doc_type is dropped
    before indexing, and recorded under the ``admin_disabled`` reason."""
    from nextcloud_mcp_server.vector.scanner import DocumentTask

    doc_task = DocumentTask(
        user_id="alice",
        doc_id="42",
        doc_type="note",
        operation="index",
        modified_at=0,
        file_path="/x.md",  # set so the tag-reconcile branch is skipped
    )

    mocker.patch.object(
        processor,
        "get_qdrant_client",
        mocker.AsyncMock(return_value=mocker.MagicMock()),
    )
    # Admin disabled everything → note is not allowed.
    mocker.patch.object(
        processor, "allowed_doc_types", mocker.AsyncMock(return_value=frozenset())
    )
    index = mocker.patch.object(processor, "_index_document")
    rec = mocker.patch.object(processor, "record_ingest_dropped")

    await processor.process_document(doc_task, mocker.MagicMock(), max_retries=1)

    index.assert_not_called()
    rec.assert_called_once_with("admin_disabled")


@pytest.mark.unit
async def test_process_document_allows_when_doc_type_approved(mocker):
    """The consent gate does not drop an index task for an allowed doc_type."""
    from nextcloud_mcp_server.vector.scanner import DocumentTask

    doc_task = DocumentTask(
        user_id="alice",
        doc_id="42",
        doc_type="note",
        operation="index",
        modified_at=0,
        file_path="/x.md",
    )

    mocker.patch.object(
        processor,
        "get_qdrant_client",
        mocker.AsyncMock(return_value=mocker.MagicMock()),
    )
    mocker.patch.object(
        processor,
        "allowed_doc_types",
        mocker.AsyncMock(return_value=frozenset({"note"})),
    )
    index = mocker.patch.object(
        processor, "_index_document", mocker.AsyncMock(return_value=1)
    )
    rec = mocker.patch.object(processor, "record_ingest_dropped")

    await processor.process_document(doc_task, mocker.MagicMock(), max_retries=1)

    index.assert_awaited()  # indexing proceeded
    rec.assert_not_called()