Chris CoutinhoandClaude Opus 4.8
ef5b3f3873
Consume the astrolabe.semantic_search capability as the source of truth for which content sources an admin has approved for semantic search, and enforce it independently of Astrolabe (this server queries Qdrant directly). - capabilities.py: cached per-user reader for enabled_doc_types (TTL+LRU, fail-open so older Astrolabe / transient OCS errors don't break search) - semantic search: intersect requested doc_types with the allowed set; restrict to the allowed set when none requested; short-circuit when empty - scanner: skip disabled sources during discovery (files discovery yields nothing when disabled, so the existing grace-period reconcile purges them) - processor: drop near-real-time index tasks for disabled doc_types (webhook events bypass the scanner gate); deletes always proceed - vector/purge.py + POST /api/v1/vector-sync/purge: admin-only global delete-by-doc_type, called by Astrolabe when a source is disabled so consent is binding on data-at-rest Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
145 lines
4.5 KiB
Python
145 lines
4.5 KiB
Python
"""Unit tests for the Astrolabe searchable-sources capability reader."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import nextcloud_mcp_server.capabilities as cap
|
|
from nextcloud_mcp_server.capabilities import (
|
|
_parse_enabled_doc_types,
|
|
allowed_doc_types,
|
|
clear_cache,
|
|
is_doc_type_allowed,
|
|
)
|
|
|
|
|
|
def _payload(enabled_doc_types) -> dict:
|
|
"""Build an OCS capabilities envelope carrying the astrolabe block.
|
|
|
|
``enabled_doc_types=...`` (Ellipsis) omits the key entirely.
|
|
"""
|
|
semantic: dict = {}
|
|
if enabled_doc_types is not ...:
|
|
semantic["enabled_doc_types"] = enabled_doc_types
|
|
return {
|
|
"ocs": {
|
|
"meta": {"status": "ok"},
|
|
"data": {"capabilities": {"astrolabe": {"semantic_search": semantic}}},
|
|
}
|
|
}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _parse_enabled_doc_types
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_parse_present_list_returns_set():
|
|
assert _parse_enabled_doc_types(_payload(["note", "file"])) == {"note", "file"}
|
|
|
|
|
|
def test_parse_empty_list_returns_empty_set():
|
|
# Admin disabled every source — distinct from "no restriction".
|
|
assert _parse_enabled_doc_types(_payload([])) == set()
|
|
|
|
|
|
def test_parse_missing_astrolabe_block_returns_none():
|
|
payload = {"ocs": {"data": {"capabilities": {}}}}
|
|
assert _parse_enabled_doc_types(payload) is None
|
|
|
|
|
|
def test_parse_missing_enabled_key_returns_none():
|
|
assert _parse_enabled_doc_types(_payload(...)) is None
|
|
|
|
|
|
def test_parse_malformed_payload_returns_none():
|
|
assert _parse_enabled_doc_types(None) is None
|
|
assert _parse_enabled_doc_types({"ocs": "nope"}) is None
|
|
assert _parse_enabled_doc_types(_payload("not-a-list")) is None
|
|
|
|
|
|
def test_parse_drops_non_string_entries():
|
|
assert _parse_enabled_doc_types(_payload(["note", 5, None])) == {"note"}
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# is_doc_type_allowed
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def test_is_doc_type_allowed_none_means_no_restriction():
|
|
assert is_doc_type_allowed("anything", None) is True
|
|
|
|
|
|
def test_is_doc_type_allowed_respects_set():
|
|
allowed = frozenset({"note"})
|
|
assert is_doc_type_allowed("note", allowed) is True
|
|
assert is_doc_type_allowed("file", allowed) is False
|
|
|
|
|
|
def test_is_doc_type_allowed_empty_set_blocks_all():
|
|
assert is_doc_type_allowed("note", frozenset()) is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# allowed_doc_types (cache + fail-open)
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class _FakeClient:
|
|
def __init__(self, payload=None, raises: Exception | None = None):
|
|
self._payload = payload
|
|
self._raises = raises
|
|
self.calls = 0
|
|
|
|
async def capabilities(self):
|
|
self.calls += 1
|
|
if self._raises is not None:
|
|
raise self._raises
|
|
return self._payload
|
|
|
|
|
|
async def test_allowed_doc_types_parses_and_caches():
|
|
clear_cache()
|
|
client = _FakeClient(_payload(["note", "file"]))
|
|
|
|
first = await allowed_doc_types(client, "alice")
|
|
second = await allowed_doc_types(client, "alice")
|
|
|
|
assert first == frozenset({"note", "file"})
|
|
assert second == frozenset({"note", "file"})
|
|
# Second call served from the cache — only one OCS round-trip.
|
|
assert client.calls == 1
|
|
|
|
|
|
async def test_allowed_doc_types_missing_block_returns_none():
|
|
clear_cache()
|
|
client = _FakeClient({"ocs": {"data": {"capabilities": {}}}})
|
|
assert await allowed_doc_types(client, "bob") is None
|
|
|
|
|
|
async def test_allowed_doc_types_fail_open_not_cached():
|
|
clear_cache()
|
|
client = _FakeClient(raises=RuntimeError("ocs down"))
|
|
|
|
assert await allowed_doc_types(client, "carol") is None
|
|
# Failures are not cached — the next call retries the OCS lookup.
|
|
assert await allowed_doc_types(client, "carol") is None
|
|
assert client.calls == 2
|
|
|
|
|
|
async def test_allowed_doc_types_cache_is_per_user():
|
|
clear_cache()
|
|
alice = _FakeClient(_payload(["note"]))
|
|
bob = _FakeClient(_payload(["file"]))
|
|
|
|
assert await allowed_doc_types(alice, "alice") == frozenset({"note"})
|
|
assert await allowed_doc_types(bob, "bob") == frozenset({"file"})
|
|
|
|
|
|
async def test_clear_cache_forces_refetch():
|
|
clear_cache()
|
|
client = _FakeClient(_payload(["note"]))
|
|
await allowed_doc_types(client, "dave")
|
|
cap.clear_cache()
|
|
await allowed_doc_types(client, "dave")
|
|
assert client.calls == 2
|